Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graph): add tooltips to docs graph #13832

Merged
merged 2 commits into from
Dec 16, 2022
Merged

feat(graph): add tooltips to docs graph #13832

merged 2 commits into from
Dec 16, 2022

Conversation

philipjfulcher
Copy link
Collaborator

@philipjfulcher philipjfulcher commented Dec 14, 2022 •
edited
Loading

Current Behavior

  • Tooltips are not available on graphs on docs pages

Expected Behavior

  • Tooltips are available on graph on docs pages

@vercel
Copy link

vercel bot commented Dec 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 8:58PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Dec 14, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 816a323. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 11 targets

Sent with 💌 from NxCloud.

@philipjfulcher philipjfulcher marked this pull request as ready for review December 15, 2022 17:11
@isaacplmann
Copy link
Collaborator

Could you turn tooltips on for one graph in the docs so we can see a preview?

I skimmed through the 100 files changes, but I didn't do an in depth review.

bcabanes
bcabanes reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@bcabanes bcabanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the fact that this feature is only a one liner for nx.dev 🔥
nx-dev/ui-markdoc/src/lib/tags/graph.component.tsx

@philipjfulcher
Copy link
Collaborator Author

Could you turn tooltips on for one graph in the docs so we can see a preview?

I skimmed through the 100 files changes, but I didn't do an in depth review.

Here's a graph with tooltips enabled: https://nx-5wdsy7x4d-nrwl.vercel.app/core-features/explore-graph

isaacplmann
isaacplmann approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@philipjfulcher philipjfulcher merged commit 578ecb6 into nrwl:master Dec 16, 2022
@philipjfulcher philipjfulcher deleted the docs-graph-tooltips branch December 19, 2022 15:38
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isaacplmann isaacplmann isaacplmann approved these changes

@bcabanes bcabanes bcabanes approved these changes

Assignees

@philipjfulcher philipjfulcher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philipjfulcher @isaacplmann @bcabanes